Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BrazilKing's 'mini' piece set #16476

Closed
wants to merge 14 commits into from

Conversation

Leo-Berman
Copy link

Create a PR for BrazilKing's chest pieces. Important to note I had nothing to do with the art, but I tried to take some work off the open-source contributors. Not exactly sure how the base 64 encoding works.

Based off of this pull request: https://github.com/lichess-org/lila/pull/15444/files

Feel free to contact me or BrazilKing at our discord:
BettyMyAtomicDog
brazilking90

@ornicar
Copy link
Collaborator

ornicar commented Nov 26, 2024

image

@Leo-Berman
Copy link
Author

I don't think this is what they're supposed to look like I will let BrazilKing know here is the goal I believe Mini_set_for_Lichess.png

@BrazilKing
Copy link

I don't think this is what they're supposed to look like I will let BrazilKing know here is the goal I believe Mini_set_for_Lichess.png

that is correct. The pieces appear stretched and that is because I cropped the area of the chess square. It is not supposed to look like that and I will fix the svg exports asap.

@BrazilKing
Copy link

BrazilKing commented Nov 26, 2024

hereby I upload three sets which I will allow to be available only on Lichess:

  • Mega set
  • Mini set (with fixed proportions, please update)
  • Newly added: Mint set to add some more subtle color variation to the currently available chess sets.

Preview mint set: IMG_20241127_010801_176

Each piece has the requested filename and is in the correct file format.

Chess Set Mint (Fernando Custom Designs).zip
Chess Set Mega (Fernando Custom Designs).zip
Chess Set Mini Fixed (Fernando Custom Designs).zip

Let me know if you need anything else.

Fernando Custom Designs

@BrazilKing
Copy link

Updating svgs based on the provided feedback in Discord, please stand by until I have reuploaded them here.

@ornicar
Copy link
Collaborator

ornicar commented Dec 1, 2024

Thanks, but I have decided against adding this set. We already have too many pieces sets.

@ornicar ornicar closed this Dec 1, 2024
@BrazilKing
Copy link

Then allow us at least to add our own chess set in the website, for the ones who know how to make vector graphics. It would be better to have even more variation in the chess pieces. It's a way to fully customize our chess experience to our liking.

@ornicar
Copy link
Collaborator

ornicar commented Dec 1, 2024

@BrazilKing
Copy link

https://lichess.org/page/userstyles

Awesome, good for pc but i play chess on my tablet. I haven't seen a way yet to get that working on Android. If there is a way to get that working on Android, let me know.

@schlawg
Copy link
Collaborator

schlawg commented Dec 5, 2024

not with chrome. i think you can install stylus on firefox or the chromium based kiwi browser.

i do not use android so please consult the interwebs if you decide to pursue this and have further questions

@BrazilKing
Copy link

Chromium browsers on android don't support extensions. I did found this which may just work on Android: changing the svg files in the Lichess apk: https://lichess.org › lichess-feedback
[tuto] customs pieces & board

Guess I'll try that out soon. Thank you for the helpfulness.

@BrazilKing
Copy link

Right now everything has been fixed completely. All pieces are in true vector graphics format. I want this set implemented in LIchess since lichess does not have a lot of variation in the chess sets and the amount of lichess only sets are way too limited. My handmade chess set, made from scratch will greatly help to improve your collection of chess pieces. To be honest, most chess sets available in LIchess do not appeal to me at all and I am not the only one who thinks like that. Please reconsider your decision and allow my set to be included. Here is a preview of the new SVG files in action through Stylus:

Screenshot_2024-12-09-22-55-58-940_io github forkmaintainers iceraven

@BrazilKing
Copy link

bB
bK
bN
bP
bQ
bR
wB
wK
wN
wP
wQ
wR

@BrazilKing
Copy link

BrazilKing commented Dec 10, 2024

And here is the set in black and white:

Set name: Classic (more appropiate name imo)

bB
bK
bN
bP
bQ
bR
wB
wK
wN
wP
wQ
wR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants